Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Cut chat debuff information output #270

Closed
careful7j opened this issue Dec 13, 2016 · 29 comments
Closed

[Request] Cut chat debuff information output #270

careful7j opened this issue Dec 13, 2016 · 29 comments
Labels

Comments

@careful7j
Copy link

careful7j commented Dec 13, 2016

Please add a file where we can override Debuff names and output format of {debuff_list}. It's too much of text (especially on Russian localization) like:

Ослабляющее тройное возмездие VI 66.5% (00:40) | Милосердие кузнеца 33.3% (00:20) | e.t.c.

  1. Some skill names are Loooooooong ('Ослабляющее тройное возмездие' - just OMG) can I somewhere in Shinra modify this skill names?
  2. Time (00:40) is also consuming space in chat (I Believe percentage (66.5%) could be just enough)
  3. Skilll level in chat "VI" <- something I defenetely don't need.

Perfect output would look like:
Возмездие 66.5% | Милосердие 33.3% | e.t.c.

Please save my chat from garbage :D Thank you for the job already done, Shinra the best :)

@Owyn
Copy link
Contributor

Owyn commented Dec 13, 2016

+1

@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

Don't see the way to create short name automatically, but I can add short name to meter, if someone send me override file (something like hotdot-short-RU.tsv) in format

<id> <short name>

Not sure, where to add it, to DB (so that it will autoupdate with meter) or to user config, so that user changes to this file will be persistent.

@Owyn
Copy link
Contributor

Owyn commented Dec 13, 2016

Alternatively - could you do a priority for displaying debuffs? like "Милосердие кузнеца" and Velika's Mark of Archer is pretty worthless to know, but on the other hand debuffs of healers and then tanks are very important to know:
see, useless stuff now comes first and important one gets cut
tera_screenshot_20161213_213422_proc

@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

Again, don't see the way to prioritize it automatically. Now it's shown in order of appearing on boss.
override file is probably the best way, cause there is not so many debuffs available on boss and it can be written manually.

@careful7j
Copy link
Author

And what about modifying the output schema - "debuff name" + "debuff level" + "percentage" + "time" - is there any xml file where can I find it and fix the way I Like?

@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

I'll strip time in next release, "debuff name"+"debuff level" is actually debuff name, will be substituted with short name, if we implement overrides

@Owyn
Copy link
Contributor

Owyn commented Dec 13, 2016

I'll strip time in next release

but time is needed ...

not only percents, by time we can see how much procs there was like if it's 0:20 - hurricane proced just once, both percentage and time are needed to be shown

I think just short names would do the trick and there won't be anymore "message length limit" problem

Gl0 added a commit to neowutran/Tera that referenced this issue Dec 13, 2016
…>.tsv

file is optional, format is `<id> <shortname>`.
If no override exist - use full name.
neowutran/ShinraMeter#270
@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

The only way I see - add something like {debuff_list_p} for only % output

@Owyn
Copy link
Contributor

Owyn commented Dec 13, 2016

The only way I see - add something like {debuff_list_p} for only % output

How would people know to what debuff the % belongs then?...

@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

I've mean without time version

@Owyn
Copy link
Contributor

Owyn commented Dec 13, 2016

I wonder if people would use that {debuff_list_p} ...

@careful7j wrote about changing the whole hardcoded schema for debuff_list display, not really about one specific variation without time

@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

You see one as issue starter.=)

Gl0 added a commit that referenced this issue Dec 13, 2016
…ents in debuff_list without exact times #270

Removed enrage % from {debuff_list} #267
Add {debuff_list} and {debuff_list_p} placeholders to the footer for those, who want to see all debuffs below dps stats.
Replace full debuff name with short debuff name in paste string if override file exists in meter db.
@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

Still need someone to supply desired short names for debuffs, that will be understandable for the majority of meter users in the region.

@Owyn
Copy link
Contributor

Owyn commented Dec 13, 2016

@Gl0
Can you dump a file with full names so people would just edit those to desired? That'd be the easiest way

@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

All full names and id's are in ./resources/data/hotdot/hotdot-RU.tsv
I don't know which debuffs can be placed on boss, you should know it better, cause you see them every day in dungeons. (No need to list all names, need only those, which are too long to be used as is)

@Owyn
Copy link
Contributor

Owyn commented Dec 13, 2016

So you do have skill descriptions.. but when I hover buffs in shinra window they don't show any description up...

@Gl0
Copy link
Collaborator

Gl0 commented Dec 14, 2016

Description is shown when hovering over debuff name.
Id is shown on uptime %

@careful7j
Copy link
Author

careful7j commented Dec 14, 2016

I'll try to collect long debuff names today and publish it here in the end of the day.

And well... as "Owyn" mentioned above, for some debuffs time is more important than precentage (i.e. Hurricane). Looks like there it's not that easy task.
Owyn, are there any more debuffs except Hurricane that are important to have time?

@Owyn
Copy link
Contributor

Owyn commented Dec 14, 2016

are there any more debuffs except Hurricane that are important to have time?

can't recall any

I'll try to collect long debuff names today and publish it here in the end of the day.

don't forget tank debuffs of:
brawler
lancer
warrior (tank-stance)
berserker (tank-stance)

@Owyn
Copy link
Contributor

Owyn commented Dec 14, 2016

@Gl0

Again, don't see the way to prioritize it automatically. Now it's shown in order of appearing on boss.

Some sort of sorting would be nice:

to always have priest debuffs come first, then mystic, then tank etc,

else people would be always confused searching for debuff names in unknown places when trying to know the uptime, - it's like if DPS was always shown in different place every fight (or for every player lol) (at the start, or in the middle, or at the end)

@Gl0
Copy link
Collaborator

Gl0 commented Dec 14, 2016

I can sort it by player class, but ingame order of classes is far from what you want. Also can sort it by uptime % (same as on moongourd)

@Owyn
Copy link
Contributor

Owyn commented Dec 14, 2016

Well, sorting by uptime is better than how it is currently, so yes please.

Gl0 added a commit that referenced this issue Dec 14, 2016
@careful7j
Copy link
Author

Yesterday collected this (after -> suggested short version):
Ослабляющий град проклятий -> Град проклятий
Ослабляющее тройное возмездие -> Тройное
Броня: ураган -> Ураган
Милосердие кузнеца -> ВМ8
Прорезающий выпад -> Прорезающий
Серия взрывных ударов -> Серия
Do you need it's Ids in File or names are enough?

@Owyn
Copy link
Contributor

Owyn commented Dec 15, 2016

Ослабляющий град проклятий -> Град
Ослабляющее тройное возмездие -> Возмездие
Прорезающий выпад -> Выпад

better this way :-)

@careful7j
Copy link
Author

careful7j commented Dec 15, 2016

Ослабляющий град проклятий -> Град
Ослабляющее тройное возмездие -> Тройное
Броня: ураган -> Ураган
Милосердие кузнеца -> ВМ8
Прорезающий выпад -> Выпад
Серия взрывных ударов -> Серия
Клеймо велики -> Клеймо
Карающий удар -> Карающий
Okay, updated +archer/berserker one (now it's everything I believe)

@Owyn
Copy link
Contributor

Owyn commented Dec 15, 2016

Ослабляющее тройное возмездие -> Тройное

Ослабляющее тройное возмездие -> Возмездие

Милосердие кузнеца -> ВМ8

Милосердие кузнеца -> Милосердие

(not much longer)

@careful7j
Copy link
Author

careful7j commented Dec 15, 2016

Возмездие

May look confusing, but if you don't think so - I don't care.
Isn't 'ВМ8' shorter? However don't care again - let it be as you like if you are sure.

@Owyn
Copy link
Contributor

Owyn commented Dec 15, 2016

May look confusing

It's pretty unique word related to priest, no?

Тройное

Much more confusing in my opinion, could mean anything by "triple"

Thank you for gathering short names btw.

@careful7j
Copy link
Author

Ослабляющий град проклятий -> Град
Ослабляющее тройное возмездие -> Возмездие
Броня: ураган -> Ураган
Милосердие кузнеца -> ВМ8
Прорезающий выпад -> Выпад
Серия взрывных ударов -> Серия
Клеймо велики -> Клеймо
Карающий удар -> Карающий

Finally :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants