Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isort and linting configuration #190

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

yakky
Copy link
Member

@yakky yakky commented Jul 12, 2020

Description

Update linting with isort 5 support and update pre-commit versions

References

Fix #188

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #190 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #190   +/-   ##
========================================
  Coverage    91.80%   91.80%           
========================================
  Files            6        6           
  Lines          720      720           
  Branches       119      119           
========================================
  Hits           661      661           
  Misses          20       20           
  Partials        39       39           
Flag Coverage Δ
#unittests 91.80% <100.00%> (ø)
Impacted Files Coverage Δ
app_helper/main.py 88.37% <ø> (ø)
app_helper/base_test.py 94.66% <100.00%> (ø)
app_helper/utils.py 91.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a4c320...c608a47. Read the comment docs.

@yakky yakky merged commit 68682d3 into develop Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix isort 5 support
1 participant