-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add jinja2 support #60
base: develop
Are you sure you want to change the base?
Conversation
5e48a2d
to
b3b5123
Compare
b3b5123
to
830e9db
Compare
Codecov Report
@@ Coverage Diff @@
## develop #60 +/- ##
===========================================
- Coverage 96.9% 93.27% -3.63%
===========================================
Files 7 8 +1
Lines 355 372 +17
Branches 38 39 +1
===========================================
+ Hits 344 347 +3
- Misses 7 21 +14
Partials 4 4
Continue to review full report at Codecov.
|
2 similar comments
4 similar comments
@@ -112,6 +112,27 @@ Usage | |||
</body> | |||
</html> | |||
|
|||
#. For Jinja2 support, configure your environment:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can move the jinja2 section to a dedicated page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise it's great! Thank you for this very nice addition
See my comment related to the doc page
See also test failures
Any approach to testing this?
@prokaktus any update on this? Do you need any help to get this merged? |
@yakky hi! Thanks for your attention. I've stopped using this fix with my fork, but it would be much nicer to prepare fix for the main version! I will work for a proper fix in the following couple days. |
@prokaktus that would be awesome! Thanks and let me know if you need help. New year resolution is to be more active and helpful here :) |
Address #57