Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing role to porch rbac #85

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

efiacor
Copy link
Contributor

@efiacor efiacor commented Sep 18, 2024

No description provided.

@nephio-prow nephio-prow bot added the approved label Sep 18, 2024
@efiacor efiacor requested review from radoslawc, kispaljr, tliron and liamfallon and removed request for johnbelamaric September 18, 2024 15:02
@efiacor efiacor added the bug Something isn't working label Sep 18, 2024
@efiacor
Copy link
Contributor Author

efiacor commented Sep 18, 2024

nephio-project/porch#93

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Catalin-Stratulat-Ericsson
Copy link
Contributor

/approve

Copy link
Contributor

nephio-prow bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Catalin-Stratulat-Ericsson, efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kispaljr
Copy link

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Sep 18, 2024
@nephio-prow nephio-prow bot merged commit 826a886 into nephio-project:main Sep 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bug Something isn't working lgtm
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants