Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable gosec temporarily in Nephio repo #156

Closed
gvbalaji opened this issue May 3, 2023 · 1 comment
Closed

Disable gosec temporarily in Nephio repo #156

gvbalaji opened this issue May 3, 2023 · 1 comment
Assignees
@radoslawc
Labels
area/process-mgmt SIG Release Process Management sig/release
Milestone
sprint3

Comments

@gvbalaji
Copy link

gvbalaji commented May 3, 2023 •
edited
Loading

We have multiple artifacts built in the Nephio (https://github.com/nephio-project/nephio) repo. We have a go.mod file at the root and and one for each artifact . This is causing a few issues with gosec and the jobs are failing. In order to unblock the team let us disable gosec jobs only on this repo for now.

There will be another issue created to dive deep into this and fix it the right way that involves some reorganization of code and prow jobs.
@gvbalaji gvbalaji added sig/release area/process-mgmt SIG Release Process Management labels May 3, 2023
@gvbalaji gvbalaji moved this to In Progress in Nephio R1 May 3, 2023
@gvbalaji gvbalaji moved this from In Progress to Todo in Nephio R1 May 3, 2023
@gvbalaji gvbalaji added this to the sprint3 milestone May 3, 2023
@radoslawc radoslawc moved this from Todo to In Progress in Nephio R1 May 4, 2023
@radoslawc radoslawc mentioned this issue May 4, 2023
Merged
@radoslawc
Copy link
Contributor

Sure it just needs removing it in repo's local file .prow.yaml. I've created PR for that. We'll revert that once that's sorted.

nephio-prow bot pushed a commit that referenced this issue May 4, 2023
@radoslawc
Removed gosec test (#162)
28de0ad 
Related to #156
@radoslawc radoslawc moved this from In Progress to Done in Nephio R1 May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radoslawc radoslawc

Labels
area/process-mgmt SIG Release Process Management sig/release
Projects
Nephio R1
Status: Done
Milestone
sprint3
Development

No branches or pull requests
2 participants
@radoslawc @gvbalaji