Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porch packageRevision is not auto-incremented in case the Repository points at a directory #814

Open
nagygergo opened this issue Oct 20, 2024 · 0 comments · May be fixed by nephio-project/porch#125
Open

Porch packageRevision is not auto-incremented in case the Repository points at a directory #814

nagygergo opened this issue Oct 20, 2024 · 0 comments · May be fixed by nephio-project/porch#125
Assignees
@JamesMcDermott
Labels
area/porch Porch related issues bug Something isn't working

Comments

@nagygergo
Copy link

The behavior of package revision revision numbering is not consistent between packageRevisions that are in a Repository that has a directory field filled out and ones that are not. In case the directory field is filled out, when a second revision of a given package is approved, it also gets the v1 revision.
In case the directory is not filled out, when a second revision of a given package is approved, it will get v2 revision.
@nagygergo nagygergo added bug Something isn't working area/porch Porch related issues labels Oct 20, 2024
@JamesMcDermott JamesMcDermott linked a pull request Oct 21, 2024 that will close this issue
Open
JamesMcDermott added a commit to Nordix/porch that referenced this issue Oct 22, 2024
@JamesMcDermott
#814 - move directory matching alignment to Git side instead of Packa…
2d08746 
…geRevisionKey

- in Git-side CloseDraft method, trim directory path off full package path before
  listing PackageRevisions
  - ensuring only the package name will be used when matching PackageRevisions
    to filter out, whether or not the repo has a directory set

nephio-project/nephio#814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesMcDermott JamesMcDermott

Labels
area/porch Porch related issues bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@nagygergo @JamesMcDermott