Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib design #115

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Lib design #115

merged 3 commits into from
Apr 13, 2023

Conversation

henderiw
Copy link
Contributor

this adds the design choices for the arm function libraries

@nephio-prow nephio-prow bot requested review from s3wong and tliron April 13, 2023 14:23
@nephio-prow nephio-prow bot added the approved label Apr 13, 2023
@henderiw henderiw requested review from aakashchan, johnbelamaric, ganchandrasekaran and kispaljr and removed request for tliron April 13, 2023 14:24
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Apr 13, 2023

@henderiw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
presubmit-nephio-go-test 56d7f8d link true /test presubmit-nephio-go-test
presubmit-nephio-golangci-lint 56d7f8d link true /test presubmit-nephio-golangci-lint
presubmit-nephio-gosec 56d7f8d link true /test presubmit-nephio-gosec

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johnbelamaric
Copy link
Member

/approve
/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Apr 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henderiw, johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [henderiw,johnbelamaric]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the lgtm label Apr 13, 2023
@nephio-prow nephio-prow bot merged commit 72d493d into nephio-project:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants