Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "network reconciler" #283

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

johnbelamaric
Copy link
Member

Reverts #282

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from johnbelamaric by writing /assign @johnbelamaric in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot requested review from henderiw and tliron June 12, 2023 22:27
@johnbelamaric
Copy link
Member Author

That PR seems to cause this failure:

ubuntu@nephio-e2e-network2:~$ k -n nephio-system logs -c controller nephio-controller-78dd64c7dc-wsdz2
/manager flag redefined: alsologtostderr
panic: /manager flag redefined: alsologtostderr

goroutine 1 [running]:
flag.(*FlagSet).Var(0xc0000a2180, {0x234f3f0, 0x354b749}, {0x20103a6, 0xf}, {0x2096446, 0x49})
	/usr/local/go/src/flag/flag.go:982 +0x2f9
k8s.io/klog/v2.InitFlags.func1(0xc0000b7ec0?)
	/go/src/vendor/k8s.io/klog/v2/klog.go:437 +0x37
flag.(*FlagSet).VisitAll(0x40e007?, 0xc000225750)
	/usr/local/go/src/flag/flag.go:447 +0x49
k8s.io/klog/v2.InitFlags(0x0?)
	/go/src/vendor/k8s.io/klog/v2/klog.go:436 +0x48
main.main()
	/go/src/main.go:67 +0x9b

Oddly, when build it and run it locally on my machine, I didn't see this. But this is what I got when it ran in K8s. Which is really weird. I am going to try it again.

@johnbelamaric
Copy link
Member Author

Oh, no, it does it locally. I must have run an old copy when I tried it the first time.

@johnbelamaric johnbelamaric merged commit 8615d19 into main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant