Requeue in approval and generic specializer #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbelamaric
commented
Nov 30, 2023
There was a problem hiding this comment.
this is just gofmt
johnbelamaric
commented
Nov 30, 2023
There was a problem hiding this comment.
this is just gofmt
efiacor
reviewed
Dec 4, 2023
| @@ -47,6 +47,7 @@ const ( | |||
| DelayAnnotationName = "approval.nephio.org/delay" | |||
| PolicyAnnotationName = "approval.nephio.org/policy" | |||
| InitialPolicyAnnotationValue = "initial" | |||
| RequeueDuration = 10 * time.Second | |||
There was a problem hiding this comment.
Would it make sense to expose this in the CR?
There was a problem hiding this comment.
No, I don't think so.
|
/lgtm |
|
/approve Needs a new LGTM since I had to update it. @radoslawc maybe that's something Tide is supposed todo? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
nyrahul
pushed a commit
to nyrahul/nephio
that referenced
this pull request
Jan 3, 2024
In the most recent Porch builds, I have cleaned up a bunch of noisy watch notifications. This is a good thing, except that our approval controller and specializers were relying on the verbose watch events being thrown out. This means that our e2e test times will go up a lot if we bump Porch version. This PR resolves that, by requeueing when it makes sense to. There is more we could do (for example watching PackageVariants so we find out immediately when they flip to Ready state), but this is a good start. Here are the timings I have: | Test | R1 | Current Nephio<br/>New Porch| This PR Nephio<br/>New Porch | | ---- | ---- | ----------------------- | -------------------------| | 001.sh | 235 secs | 540 secs | 235 secs | | 002.sh | 730 secs | 1307 secs | 584 secs | | 003.sh | 112 secs | 53 secs | 69 secs | | 004.sh | 152 secs | 432 secs | 91 secs | | 005.sh | 358 secs | 388 secs | 222 secs | | 006.sh | 307 secs | 413 secs | 176 secs | | 007.sh | 371 secs | 484 secs | 186 secs | | 008.sh | 291 secs | 289 secs |67 secs | | 009.sh | 26 secs | 30 secs | 31 secs | I also added events in the approval controller for when it proposes and approves the PackageRevision.
PrimalPimmy
pushed a commit
to 5GSEC/nephio
that referenced
this pull request
Aug 2, 2024
In the most recent Porch builds, I have cleaned up a bunch of noisy watch notifications. This is a good thing, except that our approval controller and specializers were relying on the verbose watch events being thrown out. This means that our e2e test times will go up a lot if we bump Porch version. This PR resolves that, by requeueing when it makes sense to. There is more we could do (for example watching PackageVariants so we find out immediately when they flip to Ready state), but this is a good start. Here are the timings I have: | Test | R1 | Current Nephio<br/>New Porch| This PR Nephio<br/>New Porch | | ---- | ---- | ----------------------- | -------------------------| | 001.sh | 235 secs | 540 secs | 235 secs | | 002.sh | 730 secs | 1307 secs | 584 secs | | 003.sh | 112 secs | 53 secs | 69 secs | | 004.sh | 152 secs | 432 secs | 91 secs | | 005.sh | 358 secs | 388 secs | 222 secs | | 006.sh | 307 secs | 413 secs | 176 secs | | 007.sh | 371 secs | 484 secs | 186 secs | | 008.sh | 291 secs | 289 secs |67 secs | | 009.sh | 26 secs | 30 secs | 31 secs | I also added events in the approval controller for when it proposes and approves the PackageRevision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the most recent Porch builds, I have cleaned up a bunch of noisy watch notifications. This is a good thing, except that our approval controller and specializers were relying on the verbose watch events being thrown out. This means that our e2e test times will go up a lot if we bump Porch version. This PR resolves that, by requeueing when it makes sense to. There is more we could do (for example watching PackageVariants so we find out immediately when they flip to Ready state), but this is a good start. Here are the timings I have:
New Porch
New Porch
I also added events in the approval controller for when it proposes and approves the PackageRevision.