-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed configsync dependency #455
Conversation
So this PR adds 2 changes to make it independent on configsync.
|
@henderiw If I understand correctly I still have to create the secret in the management cluster right? Only then Nephio-Controller will act on it. In this case is it possible to add a possibility to populate the secret in the multiple clusters? |
right now there is a clusterName we lookup because we need to find the credentials of the remote cluster. I also believe it is bad practice to reuse a secret in multiple places, because a break means you have to update all of them. |
But in skupper that's how a link between two sites is created, a secret is shared between clusters (same namespaces). |
@arora-sagar I added logic to add the secret to a multiple clusters. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, henderiw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Removed the dependency to configsync namespace, but we need to see if the namespace is to be set.
Removed the dependency to configsync namespace, but we need to see if the namespace is to be set.