Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only overwrite the specific annotations #456

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

henderiw
Copy link
Contributor

@henderiw henderiw commented Dec 6, 2023

We were resetting all annotations instead we update the specific once that became specific to the remote cluster

@nephio-prow nephio-prow bot requested review from s3wong and tliron December 6, 2023 08:10
@liamfallon
Copy link
Member

It would be great to get the formatting changes and the code changes in separate PRs. It would make it easier to spot the changes.

@liamfallon
Copy link
Member

/approve

@efiacor
Copy link
Collaborator

efiacor commented Dec 6, 2023

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Dec 6, 2023
@henderiw
Copy link
Contributor Author

henderiw commented Dec 6, 2023

/approve

Copy link
Contributor

nephio-prow bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, henderiw, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Dec 6, 2023
@nephio-prow nephio-prow bot merged commit f48b66a into nephio-project:main Dec 6, 2023
PrimalPimmy pushed a commit to 5GSEC/nephio that referenced this pull request Aug 2, 2024
We were resetting all annotations instead we update the specific once
that became specific to the remote cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants