Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update porch dependencies to nephio porch modules #781

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

efiacor
Copy link
Contributor

@efiacor efiacor commented Jul 25, 2024

#779

Main change here was to remove the use of the replace directive for porch in the go.mod files.
Update the import paths.
Minor code updates.
Update the other dependencies to satisfy the existing codebase.

@nephio-prow nephio-prow bot requested review from henderiw and s3wong July 25, 2024 17:21
@efiacor efiacor requested review from kispaljr, tliron, johnbelamaric, liamfallon and vjayaramrh and removed request for s3wong July 25, 2024 17:22
@efiacor
Copy link
Contributor Author

efiacor commented Jul 25, 2024

/retest

@radoslawc
Copy link
Contributor

/override presubmit-nephio-lichen
this is false positive and needs further investigation

Copy link
Contributor

nephio-prow bot commented Jul 25, 2024

@radoslawc: Overrode contexts on behalf of radoslawc: presubmit-nephio-lichen

In response to this:

/override presubmit-nephio-lichen
this is false positive and needs further investigation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kispaljr
Copy link
Contributor

changes look good and unit tests are all green on my machine

/lgtm

@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jul 29, 2024
@liamfallon
Copy link
Member

/test presubmit-nephio-golangci-lint

@nephio-prow nephio-prow bot removed the lgtm label Jul 29, 2024
@radoslawc
Copy link
Contributor

/test presubmit-nephio-lichen

@henderiw
Copy link
Contributor

I could not test but overall
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jul 29, 2024
@nephio-prow nephio-prow bot merged commit d98bcef into nephio-project:main Jul 29, 2024
12 checks passed
@efiacor efiacor deleted the repoint_porch_dep branch July 30, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants