adds support for unit tests, golangci-lint and gosec #83

vjayaramrh · 2023-04-01T03:00:36Z

adds support for running unit tests inside of containers, generates html output file to visualize code coverage by tests
adds support for running golangci-lint inside of containers (https://golangci-lint.run/)
adds support for running gosec inside of containers (https://github.com/securego/gosec)

linux-foundation-easycla · 2023-04-01T03:00:39Z

The committers listed above are authorized under a signed CLA.

✅ login: vjayaramrh / name: Vishwanath Jayaraman (03feecb)

vjayaramrh · 2023-04-01T03:01:44Z

@aravind254 @radoslawc @henderiw @electrocucaracha @johnbelamaric

.golangci.yml

gvbalaji · 2023-04-03T22:34:45Z

@vjayaramrh @radoslawc can you please take care of this PR as well while creating prow jobs for this repo?

Makefile

electrocucaracha

@vjayaramrh I tried to run it but I got the following error:

$ make unit
Makefile:20: *** missing separator (did you mean TAB instead of 8 spaces?).  Stop.

After replacing the spaces with tabs, I was eable to run it.

diff --git a/Makefile b/Makefile
index cf282a5..6950216 100644
--- a/Makefile
+++ b/Makefile
@@ -17,37 +17,37 @@ CONTAINER_RUNNABLE ?= $(shell $(CONTAINER_RUNTIME) -v > /dev/null 2>&1; echo $$?
 .PHONY: unit_clean
 unit_clean: ## clean up the unit test artifacts created
 ifeq ($(CONTAINER_RUNNABLE), 0)
-         $(CONTAINER_RUNTIME) system prune -f
+       $(CONTAINER_RUNTIME) system prune -f
 endif
-        rm ${TEST_COVERAGE_FILE} ${TEST_COVERAGE_HTML_FILE} ${TEST_COVERAGE_FUNC_FILE} > /dev/null 2>&1
+       rm ${TEST_COVERAGE_FILE} ${TEST_COVERAGE_HTML_FILE} ${TEST_COVERAGE_FUNC_FILE} > /dev/null 2>&1
 
 .PHONY: unit
 unit: ## Run unit tests against code.
 ifeq ($(CONTAINER_RUNNABLE), 0)
-         $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/library/golang:${GO_VERSION}-alpine3.17 \
-         /bin/sh -c "go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}; \
-         go tool cover -html=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_HTML_FILE}; \
-         go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}"
+       $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/library/golang:${GO_VERSION}-alpine3.17 \
+       /bin/sh -c "go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}; \
+       go tool cover -html=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_HTML_FILE}; \
+       go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}"
 else
-         go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}
-         go tool cover -html=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_HTML_FILE}
-         go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}
+       go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}
+       go tool cover -html=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_HTML_FILE}
+       go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}
 endif
 
 # Install link at https://golangci-lint.run/usage/install/ if not running inside a container
 .PHONY: lint
 lint: ## Run lint  against code.
 ifeq ($(CONTAINER_RUNNABLE), 0)
-         $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/golangci/golangci-lint:${GOLANG_CI_VER}-alpine golangci-lint run ./... -v
+       $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/golangci/golangci-lint:${GOLANG_CI_VER}-alpine golangci-lint run ./... -v
 else
-         golangci-lint run ./... -v
+       golangci-lint run ./... -v
 endif
 
 # Install link at https://github.com/securego/gosec#install if not running inside a container
 .PHONY: gosec
 gosec: ## inspects source code for security problem by scanning the Go Abstract Syntax Tree
 ifeq ($(CONTAINER_RUNNABLE), 0)
-         $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/securego/gosec:${GOSEC_VER} ./...
+       $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/securego/gosec:${GOSEC_VER} ./...
 else
-         gosec ./...
+       gosec ./...
 endif

I couldn't add the suggestion into the PR, but those are the changes. BTW, I got failures given this repo doesn't contain go lang source so I guess that's normal

vjayaramrh · 2023-04-04T15:47:37Z

@vjayaramrh I tried to run it but I got the following error:

$ make unit
Makefile:20: *** missing separator (did you mean TAB instead of 8 spaces?).  Stop.

After replacing the spaces with tabs, I was eable to run it.

diff --git a/Makefile b/Makefile
index cf282a5..6950216 100644
--- a/Makefile
+++ b/Makefile
@@ -17,37 +17,37 @@ CONTAINER_RUNNABLE ?= $(shell $(CONTAINER_RUNTIME) -v > /dev/null 2>&1; echo $$?
 .PHONY: unit_clean
 unit_clean: ## clean up the unit test artifacts created
 ifeq ($(CONTAINER_RUNNABLE), 0)
-         $(CONTAINER_RUNTIME) system prune -f
+       $(CONTAINER_RUNTIME) system prune -f
 endif
-        rm ${TEST_COVERAGE_FILE} ${TEST_COVERAGE_HTML_FILE} ${TEST_COVERAGE_FUNC_FILE} > /dev/null 2>&1
+       rm ${TEST_COVERAGE_FILE} ${TEST_COVERAGE_HTML_FILE} ${TEST_COVERAGE_FUNC_FILE} > /dev/null 2>&1
 
 .PHONY: unit
 unit: ## Run unit tests against code.
 ifeq ($(CONTAINER_RUNNABLE), 0)
-         $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/library/golang:${GO_VERSION}-alpine3.17 \
-         /bin/sh -c "go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}; \
-         go tool cover -html=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_HTML_FILE}; \
-         go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}"
+       $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/library/golang:${GO_VERSION}-alpine3.17 \
+       /bin/sh -c "go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}; \
+       go tool cover -html=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_HTML_FILE}; \
+       go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}"
 else
-         go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}
-         go tool cover -html=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_HTML_FILE}
-         go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}
+       go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}
+       go tool cover -html=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_HTML_FILE}
+       go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}
 endif
 
 # Install link at https://golangci-lint.run/usage/install/ if not running inside a container
 .PHONY: lint
 lint: ## Run lint  against code.
 ifeq ($(CONTAINER_RUNNABLE), 0)
-         $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/golangci/golangci-lint:${GOLANG_CI_VER}-alpine golangci-lint run ./... -v
+       $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/golangci/golangci-lint:${GOLANG_CI_VER}-alpine golangci-lint run ./... -v
 else
-         golangci-lint run ./... -v
+       golangci-lint run ./... -v
 endif
 
 # Install link at https://github.com/securego/gosec#install if not running inside a container
 .PHONY: gosec
 gosec: ## inspects source code for security problem by scanning the Go Abstract Syntax Tree
 ifeq ($(CONTAINER_RUNNABLE), 0)
-         $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/securego/gosec:${GOSEC_VER} ./...
+       $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/securego/gosec:${GOSEC_VER} ./...
 else
-         gosec ./...
+       gosec ./...
 endif

I couldn't add the suggestion into the PR, but those are the changes. BTW, I got failures given this repo doesn't contain go lang source so I guess that's normal

@vjayaramrh I tried to run it but I got the following error:

$ make unit
Makefile:20: *** missing separator (did you mean TAB instead of 8 spaces?).  Stop.

After replacing the spaces with tabs, I was eable to run it.

diff --git a/Makefile b/Makefile
index cf282a5..6950216 100644
--- a/Makefile
+++ b/Makefile
@@ -17,37 +17,37 @@ CONTAINER_RUNNABLE ?= $(shell $(CONTAINER_RUNTIME) -v > /dev/null 2>&1; echo $$?
 .PHONY: unit_clean
 unit_clean: ## clean up the unit test artifacts created
 ifeq ($(CONTAINER_RUNNABLE), 0)
-         $(CONTAINER_RUNTIME) system prune -f
+       $(CONTAINER_RUNTIME) system prune -f
 endif
-        rm ${TEST_COVERAGE_FILE} ${TEST_COVERAGE_HTML_FILE} ${TEST_COVERAGE_FUNC_FILE} > /dev/null 2>&1
+       rm ${TEST_COVERAGE_FILE} ${TEST_COVERAGE_HTML_FILE} ${TEST_COVERAGE_FUNC_FILE} > /dev/null 2>&1
 
 .PHONY: unit
 unit: ## Run unit tests against code.
 ifeq ($(CONTAINER_RUNNABLE), 0)
-         $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/library/golang:${GO_VERSION}-alpine3.17 \
-         /bin/sh -c "go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}; \
-         go tool cover -html=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_HTML_FILE}; \
-         go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}"
+       $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/library/golang:${GO_VERSION}-alpine3.17 \
+       /bin/sh -c "go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}; \
+       go tool cover -html=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_HTML_FILE}; \
+       go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}"
 else
-         go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}
-         go tool cover -html=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_HTML_FILE}
-         go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}
+       go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}
+       go tool cover -html=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_HTML_FILE}
+       go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}
 endif
 
 # Install link at https://golangci-lint.run/usage/install/ if not running inside a container
 .PHONY: lint
 lint: ## Run lint  against code.
 ifeq ($(CONTAINER_RUNNABLE), 0)
-         $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/golangci/golangci-lint:${GOLANG_CI_VER}-alpine golangci-lint run ./... -v
+       $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/golangci/golangci-lint:${GOLANG_CI_VER}-alpine golangci-lint run ./... -v
 else
-         golangci-lint run ./... -v
+       golangci-lint run ./... -v
 endif
 
 # Install link at https://github.com/securego/gosec#install if not running inside a container
 .PHONY: gosec
 gosec: ## inspects source code for security problem by scanning the Go Abstract Syntax Tree
 ifeq ($(CONTAINER_RUNNABLE), 0)
-         $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/securego/gosec:${GOSEC_VER} ./...
+       $(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/securego/gosec:${GOSEC_VER} ./...
 else
-         gosec ./...
+       gosec ./...
 endif

I couldn't add the suggestion into the PR, but those are the changes. BTW, I got failures given this repo doesn't contain go lang source so I guess that's normal

I have fixed the space vs TAB issue, would appreciate if you can confirm it is resolved

electrocucaracha

/lgtm

nephio-prow · 2023-04-04T16:17:39Z

@electrocucaracha: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

electrocucaracha · 2023-04-04T16:19:54Z

/assign @johnbelamaric

henderiw · 2023-04-04T18:24:20Z

I don't have Podman installed and got this error:

podman run -it -v /Users/henderiw/code/nephio/nephio-api:/go/src -w /go/src docker.io/library/golang:-alpine3.17
/bin/sh -c "go test ./... -v -coverprofile lcov.info;
go tool cover -html=lcov.info -o coverage_unit.html;
go tool cover -func=lcov.info -o func_coverage.out"
Cannot connect to Podman. Please verify your connection to the Linux system using podman system connection list, or try podman machine init and podman machine start to manage a new Linux VM
Error: unable to connect to Podman socket: Get "http://d/v4.4.2/libpod/_ping": dial unix ///var/folders/4j/6w02hpjj7z79lhld6kf7rmmm0000gn/T/podman-run--1/podman/podman.sock: connect: no such file or directory
make: *** [unit] Error 125

vishwanathj · 2023-04-04T18:26:21Z

I don't have Podman installed and got this error:

podman run -it -v /Users/henderiw/code/nephio/nephio-api:/go/src -w /go/src docker.io/library/golang:-alpine3.17 /bin/sh -c "go test ./... -v -coverprofile lcov.info; go tool cover -html=lcov.info -o coverage_unit.html; go tool cover -func=lcov.info -o func_coverage.out" Cannot connect to Podman. Please verify your connection to the Linux system using podman system connection list, or try podman machine init and podman machine start to manage a new Linux VM Error: unable to connect to Podman socket: Get "http://d/v4.4.2/libpod/_ping": dial unix ///var/folders/4j/6w02hpjj7z79lhld6kf7rmmm0000gn/T/podman-run--1/podman/podman.sock: connect: no such file or directory make: *** [unit] Error 125

@henderiw Good to know, let me investigate

Makefile

vjayaramrh · 2023-04-04T18:51:26Z

I don't have Podman installed and got this error:

podman run -it -v /Users/henderiw/code/nephio/nephio-api:/go/src -w /go/src docker.io/library/golang:-alpine3.17 /bin/sh -c "go test ./... -v -coverprofile lcov.info; go tool cover -html=lcov.info -o coverage_unit.html; go tool cover -func=lcov.info -o func_coverage.out" Cannot connect to Podman. Please verify your connection to the Linux system using podman system connection list, or try podman machine init and podman machine start to manage a new Linux VM Error: unable to connect to Podman socket: Get "http://d/v4.4.2/libpod/_ping": dial unix ///var/folders/4j/6w02hpjj7z79lhld6kf7rmmm0000gn/T/podman-run--1/podman/podman.sock: connect: no such file or directory make: *** [unit] Error 125

@henderiw I believe that you may have podman installed, but the podman machine is not running. If the podman machine is stopped, you can restart it using the command podman machine start on macbook. Let me know if this fixes the issue. Thanks

johnbelamaric

Some tools don't always put newlines at the end of files, can we see if that's a setting or something?

Makefile

nephio-prow · 2023-04-04T21:05:27Z

@henderiw: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rravindran123 · 2023-04-04T21:54:13Z

Downloaded this PR and ran the Make unit on my MAC/Docker Desktop, and it ran successfully.

/lgtm

johnbelamaric · 2023-04-05T00:28:29Z

/approve
/lgtm

johnbelamaric · 2023-04-05T00:33:00Z

@vishwanathj looks like the tab issue is still there. Perhaps the commit was never pushed?

vjayaramrh · 2023-04-05T01:26:36Z

@vishwanathj looks like the tab issue is still there. Perhaps the commit was never pushed?

strange, let me investigate

vjayaramrh · 2023-04-05T02:30:13Z

/retest

nephio-prow · 2023-04-05T02:30:28Z

@vjayaramrh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vjayaramrh · 2023-04-05T02:30:53Z

/ok-to-test

nephio-prow · 2023-04-05T02:31:09Z

@vjayaramrh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

electrocucaracha · 2023-04-05T02:37:19Z

/lgtm

nephio-prow · 2023-04-05T02:37:20Z

@electrocucaracha: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

electrocucaracha · 2023-04-05T02:57:15Z

Testing after signing CLA

/lgtm

nephio-prow · 2023-04-05T02:57:17Z

@electrocucaracha: changing LGTM is restricted to collaborators

In response to this:

Testing after signing CLA

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

henderiw · 2023-04-05T03:02:04Z

/lgtm
/approve

nephio-prow · 2023-04-05T03:02:05Z

@henderiw: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

radoslawc · 2023-04-05T14:26:57Z

Makefile

In order to change Makefile commands you have to change PROW job as well. So for example you want to add 'make unit_clean' you have to add it in .prow.yaml for example like this:

- name: presubmit-nephio-go-unit-clean decorate: true run_if_changed: "(\\.go)$" spec: containers: - image: golang:1.20.2 command: - make args: - unit_clean

@radoslawc Thanks, I shall update the PR

radoslawc · 2023-04-05T14:51:50Z

/test ?

nephio-prow · 2023-04-05T14:52:06Z

@radoslawc: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

johnbelamaric · 2023-04-05T17:00:16Z

/ok-to-test

radoslawc · 2023-04-05T17:21:06Z

Makefile

+         go tool cover -func=${TEST_COVERAGE_FILE} -o ${TEST_COVERAGE_FUNC_FILE}"
+else
+         go test ./... -v -coverprofile ${TEST_COVERAGE_FILE}


Seems like there are whitespaces there instead of tabs

henderiw · 2023-04-05T17:45:04Z

/ok-to-test

radoslawc · 2023-04-05T17:52:07Z

Makefile

+		$(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/golangci/golangci-lint:${GOLANG_CI_VER}-alpine golangci-lint run ./... -v
+else
+         golangci-lint run ./... -v


golangci-lint binary has to be installed in image used in .prow.yaml for example:

- name: presubmit-nephio-golangci-lint decorate: true run_if_changed: "(\\.go)$" spec: containers: - image: golang:1.20.2 command: - "/bin/sh" - "-c" - | wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.52.2 make lint

otherwise running it in PROW job will end up with error:

make: golangci-lint: No such file or directory

radoslawc · 2023-04-05T17:54:10Z

Makefile

+		$(CONTAINER_RUNTIME) run -it -v ${PWD}:/go/src -w /go/src docker.io/securego/gosec:${GOSEC_VER} ./...
+else
+         gosec ./...


gosec binary has to be installed in image used in .prow.yaml for example:

- name: presubmit-nephio-gosec decorate: true run_if_changed: "(\\.go)$" spec: containers: - image: golang:1.20.2 command: - "/bin/sh" - "-c" - | wget -O - -q https://raw.githubusercontent.com/securego/gosec/master/install.sh | sh -s v2.15.0 make gosec

otherwise running it in PROW job will end up with error:

make: gosec: No such file or directory

@radoslawc I see your comment about gosec here
cc: @johnbelamaric

radoslawc · 2023-04-05T17:59:23Z

We could build docker image with gosec and golangci-lint based on golang alpine image that we're using. In that way we could have uniform test across all repositories (granted people will use our image).

johnbelamaric · 2023-04-05T18:51:29Z

/approve
/lgtm

@radoslawc yes, we probably need some sort of base image for builds as well as for our functions, etc.

nephio-prow · 2023-04-05T18:51:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, henderiw, johnbelamaric, rravindran123, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [johnbelamaric]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vjayaramrh · 2023-04-05T19:06:15Z

We could build docker image with gosec and golangci-lint based on golang alpine image that we're using. In that way we could have uniform test across all repositories (granted people will use our image).

Do we need to build or use the images already published by those projects on dockerhub?

electrocucaracha reviewed Apr 1, 2023

View reviewed changes

.golangci.yml Show resolved Hide resolved

vjayaramrh mentioned this pull request Apr 2, 2023

added library to mutate the kptfile #49

Merged

electrocucaracha reviewed Apr 3, 2023

View reviewed changes

Makefile Outdated Show resolved Hide resolved

electrocucaracha suggested changes Apr 4, 2023

View reviewed changes

electrocucaracha approved these changes Apr 4, 2023

View reviewed changes

nephio-prow bot assigned johnbelamaric Apr 4, 2023

electrocucaracha reviewed Apr 4, 2023

View reviewed changes

Makefile Show resolved Hide resolved

johnbelamaric requested changes Apr 4, 2023

View reviewed changes

Makefile Outdated Show resolved Hide resolved

rravindran123 approved these changes Apr 4, 2023

View reviewed changes

nephio-prow bot added lgtm approved labels Apr 5, 2023

nephio-prow bot removed the lgtm label Apr 5, 2023

radoslawc reviewed Apr 5, 2023

View reviewed changes

nephio-prow bot added the ok-to-test label Apr 5, 2023

radoslawc reviewed Apr 5, 2023

View reviewed changes

adds support for unit tests, golangci-lint and gosec

0922fc4

nephio-prow bot added the lgtm label Apr 5, 2023

nephio-prow bot merged commit 23827e6 into nephio-project:main Apr 5, 2023

vjayaramrh deleted the unit_lint_gosec branch April 5, 2023 20:10

adds support for unit tests, golangci-lint and gosec #83

adds support for unit tests, golangci-lint and gosec #83

Conversation

vjayaramrh commented Apr 1, 2023

linux-foundation-easycla bot commented Apr 1, 2023 • edited Loading

vjayaramrh commented Apr 1, 2023

gvbalaji commented Apr 3, 2023

electrocucaracha left a comment

Choose a reason for hiding this comment

vjayaramrh commented Apr 4, 2023

electrocucaracha left a comment

Choose a reason for hiding this comment

nephio-prow bot commented Apr 4, 2023

electrocucaracha commented Apr 4, 2023

henderiw commented Apr 4, 2023

vishwanathj commented Apr 4, 2023

vjayaramrh commented Apr 4, 2023

johnbelamaric left a comment

Choose a reason for hiding this comment

nephio-prow bot commented Apr 4, 2023

rravindran123 commented Apr 4, 2023 • edited Loading

johnbelamaric commented Apr 5, 2023

johnbelamaric commented Apr 5, 2023

vjayaramrh commented Apr 5, 2023

vjayaramrh commented Apr 5, 2023

nephio-prow bot commented Apr 5, 2023

vjayaramrh commented Apr 5, 2023

nephio-prow bot commented Apr 5, 2023

electrocucaracha commented Apr 5, 2023

nephio-prow bot commented Apr 5, 2023

electrocucaracha commented Apr 5, 2023

nephio-prow bot commented Apr 5, 2023

henderiw commented Apr 5, 2023

nephio-prow bot commented Apr 5, 2023

radoslawc Apr 5, 2023

Choose a reason for hiding this comment

vjayaramrh Apr 5, 2023

Choose a reason for hiding this comment

radoslawc commented Apr 5, 2023

nephio-prow bot commented Apr 5, 2023

johnbelamaric commented Apr 5, 2023

radoslawc Apr 5, 2023

Choose a reason for hiding this comment

henderiw commented Apr 5, 2023

radoslawc Apr 5, 2023

Choose a reason for hiding this comment

radoslawc Apr 5, 2023

Choose a reason for hiding this comment

vjayaramrh Apr 7, 2023 • edited Loading

Choose a reason for hiding this comment

radoslawc commented Apr 5, 2023

johnbelamaric commented Apr 5, 2023

nephio-prow bot commented Apr 5, 2023

vjayaramrh commented Apr 5, 2023

linux-foundation-easycla bot commented Apr 1, 2023 •

edited

Loading

rravindran123 commented Apr 4, 2023 •

edited

Loading

vjayaramrh Apr 7, 2023 •

edited

Loading