Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore tutorial example configuration files #117

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

liamfallon
Copy link
Member

@liamfallon liamfallon commented Sep 27, 2024

When the tutorial documentation was moved to the "docs" repo, we did not move the example config into the examples directory in the Porch repo. This PR does that.

See also the documentation update in this PR:
nephio-project/docs#174

@liamfallon
Copy link
Member Author

/assign @efiacor @kispaljr

@efiacor
Copy link
Collaborator

efiacor commented Oct 2, 2024

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Oct 2, 2024
Copy link
Contributor

nephio-prow bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit c5599d6 into nephio-project:main Oct 2, 2024
3 of 4 checks passed
nephio-prow bot pushed a commit to nephio-project/docs that referenced this pull request Oct 4, 2024
When the tutorial documentation was moved to the "docs" repo, we did not
move the example config into the examples directory in the Porch repo.
This PR updates the tutorial to refer to the location of the tutorial
files.

See also the porch update in this PR:
nephio-project/porch#117
CsatariGergely pushed a commit to nokia/nephio-docs that referenced this pull request Oct 5, 2024
When the tutorial documentation was moved to the "docs" repo, we did not
move the example config into the examples directory in the Porch repo.
This PR updates the tutorial to refer to the location of the tutorial
files.

See also the porch update in this PR:
nephio-project/porch#117
@liamfallon liamfallon deleted the restore-tutorial-config branch October 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants