Add cabundle tls support for git repo comms

[efiacor]

This addresses nephio-project/nephio#488

[kushnaidu]

/approve

[liamfallon]

The approach and the implementation look fine to me.

[kispaljr]

Went through the code without testing it.
My only (honest) question is: why are some methods are "unimplemented" (implemented by panic("unimplemented"))? Is it by design that it should panic? If yes, should we change the string from "unimplemented" to something more descriptive?

[efiacor]

Went through the code without testing it. My only (honest) question is: why are some methods are "unimplemented" (implemented by panic("unimplemented"))? Is it by design that it should panic? If yes, should we change the string from "unimplemented" to something more descriptive?

So, with a view to keep it somewhat in the same "space" as the existing secret/credential resolver , just extended the Credential Interface.
Unfortunately I cannot use the ToAuthmethod to retrieve the cabundle secret so I added a ToString function. This then forces the impl of that function.
It's not an ideal solution and is somewhat a quick fix for now. We should look to impl a proper solution around extending the Repo CR to add auth/tls.

[kispaljr]

understood, thx for the clarification.

/lgtm

[liamfallon]

/retest

[liamfallon]

/approve
/lgtm

[nephio-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, kushnaidu, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [efiacor,liamfallon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment