Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageVariant controller: Use the default exponential back-off in case of errors, instead of a constant 30 sec retry #76

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

kispaljr
Copy link
Collaborator

@kispaljr kispaljr commented Jun 20, 2024

This improves the response times of recoverable PackageVariant errors, e.g. normal errors related to optimistic locking when updating PackageRevisionResources objects.

This should improve, but not solve nephio-project/nephio#770 and nephio-project/nephio#462 .

@kispaljr kispaljr changed the title PackageVariant controller: Use the default exponential back-off in case of errors, instead of a fix 30 sec retry PackageVariant controller: Use the default exponential back-off in case of errors, instead of a constant 30 sec retry Jun 20, 2024
@kispaljr kispaljr self-assigned this Jun 20, 2024
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

nephio-prow bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kispaljr, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 21, 2024
@kispaljr
Copy link
Collaborator Author

/retest

1 similar comment
@kispaljr
Copy link
Collaborator Author

/retest

@nephio-prow nephio-prow bot merged commit b399b8b into nephio-project:main Jun 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants