Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porchctl repo command fixes #80

Closed

Conversation

dgeorgievski
Copy link

Fixes for porchctl repo command described in nephio-project/nephio#755 issue.

I wasn't sure what approach to take for testing the repo commands. I see that repo reg command is using fake porch server. Should I follow suit for repo reg command?

2. porchctl repo reg - use current kubeconfig context namespace if it is
   not provided.
3. Use kubeconfig context namespace if flag not provided
@nephio-prow nephio-prow bot requested a review from henderiw June 24, 2024 16:22
Copy link

CLA Missing ID CLA Not Signed

Copy link
Contributor

nephio-prow bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgeorgievski
Once this PR has been reviewed and has the lgtm label, please assign s3wong for approval by writing /assign @s3wong in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot requested a review from johnbelamaric June 24, 2024 16:22
Copy link
Contributor

nephio-prow bot commented Jun 24, 2024

Hi @dgeorgievski. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgeorgievski
Copy link
Author

dgeorgievski commented Jun 24, 2024

Question about the CLA agreement. Axyom.core , my employer, is interested to sign the corporate CLA. I have a question for the email and GitHub account used in this PR.

So far, I've been working with my personal GitHub account and email address. Would I need to re-submit the PR with the corporate email and GitHub account linked to it?

@dgeorgievski
Copy link
Author

I am closing this PR and will open a new one with Axyom.Core credentials to be able to submit Corporate CLA request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant