feat: Endpoints refreshed with new Request status model and Protobuf models added #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raalsky
changed the title
Raalsky
changed the title
Raalsky
changed the title
src/neptune_api/proto/__init__.pyi
Outdated
There was a problem hiding this comment.
What's the point of this file? Cannot those imports be in the regular __init__.py?
There was a problem hiding this comment.
I'm just following what protoc and protoletariat tools gives me. The second one fixes the relative imports issue.
| @@ -13,7 +13,7 @@ | |||
| AuthenticatedClient, | |||
| Client, | |||
| ) | |||
| from ...models.ingest_response import IngestResponse | |||
| from ...proto.neptune_pb.ingest.v1.request_status_pb2 import RequestStatus | |||
There was a problem hiding this comment.
Is it possible to replace such cases with an explicit import like package1.package2.etc?
There was a problem hiding this comment.
Yes, this one shouldn't be a problem
There was a problem hiding this comment.
Done I think. There are some that were genered by client generation package that I want to leave it up to the tool itself.
AleksanderWWW
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.