-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Endpoints refreshed with new Request status model and Protobuf models added #9
Conversation
src/neptune_api/proto/__init__.pyi
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of this file? Cannot those imports be in the regular __init__.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just following what protoc
and protoletariat
tools gives me. The second one fixes the relative imports issue.
@@ -13,7 +13,7 @@ | |||
AuthenticatedClient, | |||
Client, | |||
) | |||
from ...models.ingest_response import IngestResponse | |||
from ...proto.neptune_pb.ingest.v1.request_status_pb2 import RequestStatus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to replace such cases with an explicit import like package1.package2.etc
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this one shouldn't be a problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done I think. There are some that were genered by client generation package that I want to leave it up to the tool itself.
No description provided.