Deprecation of a few methods #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 2 files - 14 2 suites - 14 1m 34s ⏱️ - 3h 25m 23s Results for commit ff0b26f. ± Comparison against base commit 6782d2f. This pull request removes 689 and adds 480 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
normandy7
reviewed
Oct 6, 2022
neptune/new/internal/init/run.py
Outdated
| @@ -159,34 +159,34 @@ def init_run( | |||
| >>> import neptune.new as neptune | |||
|
|
|||
| >>> # minimal invoke | |||
| ... run = neptune.init() | |||
| ... run = neptune.init_run() | |||
There was a problem hiding this comment.
NB: These examples are reworked by PR #1015 and the change from init to init_run is reflected there already.
There was a problem hiding this comment.
Sure. Let me know once it will be merged so I'll be able to easily get rid of it during rebasing.
normandy7
reviewed
Oct 6, 2022
Raalsky
force-pushed
the
rj/deprecated-methods
branch
from
697331f
to
a545061
Compare
shnela
reviewed
Oct 6, 2022
|
|
||
| def test_passing_deprecated_parameter_as_none(self): | ||
| # pylint: disable=unexpected-keyword-arg | ||
| # pylint: disable=missing-kwoa | ||
| self.assertIsNone(fun(deprecated_param=None)) |
There was a problem hiding this comment.
Why did we remove this line?
There was a problem hiding this comment.
Hmm, probably missed that and it should be replaced with assert value is None
Raalsky
force-pushed
the
rj/deprecated-methods
branch
from
55ab5cf
to
a243b82
Compare
Raalsky
changed the title
Raalsky
force-pushed
the
rj/deprecated-methods
branch
2 times, most recently
from
35560bc
to
5f506da
Compare
Raalsky
force-pushed
the
rj/deprecated-methods
branch
from
bc6c0f0
to
160b218
Compare
shnela
suggested changes
Oct 12, 2022
| warnings.simplefilter("always", category=NeptuneDeprecationWarning) | ||
|
|
||
|
|
||
| warned_once = {} |
There was a problem hiding this comment.
Let's make it set instead of dict
| # test collision | ||
| with self.assertRaises(NeptuneParametersCollision): | ||
| fun(new_param=None, deprecated_param=None) | ||
| def test_deprecated_func_with_alternative(self): |
There was a problem hiding this comment.
Add test for warning once ant we're done ;)
shnela
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.