Fix Artifact Tracking SQL Injection Bug #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @fmorlock-tt Thank you very much for the detailed explanation of the issue and the PR! I will talk to the engineering team and come back to you as soon as I hear from them. |
|
Hey @fmorlock-tt, I really appreciate your work! LGTM, but two minor things:
|
Raalsky
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone,
Artifact tracking appears to be broken when a parent directory contains a SQL special character. The code that I modified (
local_file_hash_storage.py) assumed that Unix paths could be injected without being escaped into SQL statements -- so I just did the standard?SQL escaping. If you are tracking artifacts in a directory that has a parent that contains, for example,'(e.g.Frederick's Workspace/) would break the SQL queries necessary for tracking artifacts.