Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled "Explore the metadata" message when stopping in debug mode #1165

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Dec 21, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 79.37% // Head: 71.14% // Decreases project coverage by -8.23% ⚠️

Coverage data is based on head (80242c7) compared to base (a815357).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
- Coverage   79.37%   71.14%   -8.24%     
==========================================
  Files         283      283              
  Lines       13379    13379              
==========================================
- Hits        10620     9518    -1102     
- Misses       2759     3861    +1102     
Flag Coverage Δ
e2e ?
unit 71.14% <100.00%> (-2.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tune/new/metadata_containers/metadata_container.py 88.03% <100.00%> (ø)
...eptune/common/websockets/reconnecting_websocket.py 27.77% <0.00%> (-63.89%) ⬇️
...tune/common/websockets/websocket_client_adapter.py 34.78% <0.00%> (-54.35%) ⬇️
...neptune/legacy/internal/utils/alpha_integration.py 41.66% <0.00%> (-45.84%) ⬇️
...ternal/threads/hardware_metric_reporting_thread.py 39.13% <0.00%> (-43.48%) ⬇️
...ernal/websockets/reconnecting_websocket_factory.py 57.14% <0.00%> (-42.86%) ⬇️
...tune/legacy/internal/streams/stdstream_uploader.py 46.87% <0.00%> (-40.63%) ⬇️
src/neptune/common/patches/bravado.py 38.88% <0.00%> (-38.89%) ⬇️
src/neptune/legacy/internal/threads/ping_thread.py 42.10% <0.00%> (-36.85%) ⬇️
...tune/new/internal/websockets/websockets_factory.py 63.63% <0.00%> (-36.37%) ⬇️
... and 91 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Raalsky Raalsky merged commit cbabe8e into master Dec 27, 2022
@Raalsky Raalsky deleted the rj/debug-stop-message branch December 27, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants