Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled info about stopping when using read-only mode #1166

Merged
merged 3 commits into from
Dec 28, 2022

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Dec 21, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 79.33% // Head: 71.39% // Decreases project coverage by -7.94% ⚠️

Coverage data is based on head (9453fd6) compared to base (18296c9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1166      +/-   ##
==========================================
- Coverage   79.33%   71.39%   -7.95%     
==========================================
  Files         282      282              
  Lines       13500    13500              
==========================================
- Hits        10710     9638    -1072     
- Misses       2790     3862    +1072     
Flag Coverage Δ
e2e ?
unit 71.39% <100.00%> (-2.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tune/new/metadata_containers/metadata_container.py 88.09% <100.00%> (ø)
...tune/common/websockets/websocket_client_adapter.py 34.78% <0.00%> (-50.01%) ⬇️
...neptune/legacy/internal/utils/alpha_integration.py 41.66% <0.00%> (-45.84%) ⬇️
...eptune/common/websockets/reconnecting_websocket.py 27.77% <0.00%> (-44.45%) ⬇️
...ternal/threads/hardware_metric_reporting_thread.py 39.13% <0.00%> (-43.48%) ⬇️
...ernal/websockets/reconnecting_websocket_factory.py 57.14% <0.00%> (-42.86%) ⬇️
...tune/legacy/internal/streams/stdstream_uploader.py 46.87% <0.00%> (-40.63%) ⬇️
src/neptune/common/patches/bravado.py 38.88% <0.00%> (-38.89%) ⬇️
src/neptune/legacy/internal/threads/ping_thread.py 42.10% <0.00%> (-36.85%) ⬇️
...ne/new/internal/backends/hosted_neptune_backend.py 42.16% <0.00%> (-35.26%) ⬇️
... and 90 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

shnela
shnela previously approved these changes Dec 27, 2022
@Raalsky Raalsky merged commit 685a31f into master Dec 28, 2022
@Raalsky Raalsky deleted the rj/readonly-stop-message-info branch December 28, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants