-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove get_project
function
#1214
Conversation
Codecov ReportBase: 71.36% // Head: 71.35% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev/1.0.0 #1214 +/- ##
=============================================
- Coverage 71.36% 71.35% -0.01%
=============================================
Files 284 284
Lines 13656 13652 -4
=============================================
- Hits 9745 9742 -3
+ Misses 3911 3910 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
CHANGELOG.md
Outdated
@@ -3,6 +3,7 @@ | |||
### Changes | |||
- Moved modules from `neptune.new` to `neptune` with compatibility imports and marked `neptune.new` as deprecated ([#1213](https://github.com/neptune-ai/neptune-client/pull/1213)) | |||
- Removed `neptune.*` legacy modules ([#1206](https://github.com/neptune-ai/neptune-client/pull/1206)) | |||
- Deprecated `get_project` function ([#1214](https://github.com/neptune-ai/neptune-client/pull/1214)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong, but it's deprecated already and actually removed with 1.0, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
get_project
functionget_project
function
src/neptune/new/sync/__init__.py
Outdated
@@ -36,7 +36,6 @@ | |||
"SyncRunner", | |||
"get_metadata_container", | |||
"get_offline_dirs", | |||
"get_project", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's too far. It's different function
src/neptune/new/sync/utils.py
Outdated
@@ -16,7 +16,6 @@ | |||
|
|||
__all__ = [ | |||
"get_metadata_container", | |||
"get_project", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's too far. It's different function #2
Before submitting checklist