Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove name parameter in init_project and management API #1227

Merged
merged 7 commits into from
Feb 15, 2023

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Feb 15, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you asked the docs owner to review all the updated user-facing interfaces?

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 71.69% // Head: 71.30% // Decreases project coverage by -0.39% ⚠️

Coverage data is based on head (eec7d7e) compared to base (e58a935).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head eec7d7e differs from pull request most recent head c7d7b3b. Consider uploading reports for the commit c7d7b3b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
- Coverage   71.69%   71.30%   -0.39%     
==========================================
  Files         284      284              
  Lines       13628    13626       -2     
==========================================
- Hits         9770     9716      -54     
- Misses       3858     3910      +52     
Flag Coverage Δ
e2e ?
unit-pull-request 71.30% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/internal/init/project.py 100.00% <ø> (ø)
src/neptune/management/internal/api.py 70.29% <ø> (-11.31%) ⬇️
src/neptune/metadata_containers/project.py 88.05% <ø> (ø)
src/neptune/internal/init/run.py 89.86% <100.00%> (+0.08%) ⬆️
.../neptune/metadata_containers/metadata_container.py 88.09% <100.00%> (+4.28%) ⬆️
...eptune/common/websockets/reconnecting_websocket.py 27.77% <0.00%> (-50.01%) ⬇️
...tune/common/websockets/websocket_client_adapter.py 34.78% <0.00%> (-50.01%) ⬇️
...neptune/legacy/internal/utils/alpha_integration.py 41.66% <0.00%> (-45.84%) ⬇️
...ternal/threads/hardware_metric_reporting_thread.py 39.13% <0.00%> (-43.48%) ⬇️
...ernal/websockets/reconnecting_websocket_factory.py 57.14% <0.00%> (-42.86%) ⬇️
... and 157 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AleksanderWWW AleksanderWWW marked this pull request as ready for review February 15, 2023 11:21
CHANGELOG.md Outdated
@@ -11,6 +11,7 @@
- Removed `model` parameter from `init_model` function ([#1223](https://github.com/neptune-ai/neptune-client/pull/1223))
- Removed `version` parameter from `init_model_version` function ([#1223](https://github.com/neptune-ai/neptune-client/pull/1223))
- Monitoring is off by default for interactive Python kernels ([#1219](https://github.com/neptune-ai/neptune-client/pull/1219))
- Removed `name` param from `init_project` and `management.api` ([#1227](https://github.com/neptune-ai/neptune-client/pull/1227))
Copy link
Collaborator

@normandy7 normandy7 Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Removed `name` param from `init_project` and `management.api` ([#1227](https://github.com/neptune-ai/neptune-client/pull/1227))
- Removed `name` parameter from the `init_project` function and management API ([#1227](https://github.com/neptune-ai/neptune-client/pull/1227))

Raalsky
Raalsky previously approved these changes Feb 15, 2023
@AleksanderWWW AleksanderWWW merged commit 8245c2b into master Feb 15, 2023
@AleksanderWWW AleksanderWWW deleted the aw/remove_name_param branch February 15, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants