Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting request timeout to 10 minutes instead of inf #1295

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Mar 14, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you asked the docs owner to review all the updated user-facing interfaces?

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -71.26 ⚠️

Comparison is base (8dbb5c5) 71.25% compared to head (f83974f) 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #1295       +/-   ##
==========================================
- Coverage   71.25%   0.00%   -71.26%     
==========================================
  Files         279     279               
  Lines       13610   13613        +3     
==========================================
- Hits         9698       0     -9698     
- Misses       3912   13613     +9701     
Flag Coverage Δ
e2e ?
unit ?
unit-pull-request 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/envs.py 0.00% <0.00%> (-100.00%) ⬇️
src/neptune/internal/backends/hosted_client.py 0.00% <0.00%> (-96.78%) ⬇️

... and 239 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Raalsky
Copy link
Contributor Author

Raalsky commented Mar 14, 2023

PatrykGala
PatrykGala previously approved these changes Mar 14, 2023
@Raalsky Raalsky changed the title Timeout was set to 10 minutes instead of unlimited for requests Setting request timeout to 10 minutes instead of inf Mar 14, 2023
@Raalsky Raalsky merged commit 30921a6 into master Mar 14, 2023
@Raalsky Raalsky deleted the rj/timeout branch March 14, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants