Fix-long-filenames for docker arguments #1305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Neptune team,
We're doing a quick prototype using your library and during the prototyping, we have faced the following easy to fix issue.
If you use a container and pass very long arguments to the container (in our case the orchestrator does it and we have no control over it), the input argument is captured within
sys.argv
and later in the code it will result in exception errorOSError: [Errno 36] File name too long
In pathlib documents it also mentions that path.is_file() can throw errors like permissions ( in our case filename being too long).
Solution:
you should use error handling. This won't usually happen in the normal execution and only happens in container-based orchestrators as one of the argv could be very long.
We're currently blocked by this issue. We'd appreciate it if you can generate a quick bugfix release from this PR. This allows us to use your library in our prototype going forward.
PS.
Thanks,
Ali
Testcase: