Added support of active projects exception #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniezurawski
requested changes
May 22, 2023
| @@ -82,6 +83,9 @@ def handle_neptune_http_errors(response, exception: Optional[HTTPError] = None): | |||
| "WORKSPACE_IN_READ_ONLY_MODE": lambda response_body: NeptuneLimitExceedException( | |||
| reason=response_body.get("title", "Unknown reason") | |||
| ), | |||
| "LIMIT_OF_ACTIVE_PROJECTS_REACHED": lambda response_body: ActiveProjectsLimitReachedException( | |||
| currentQuota=response_body.get("currentQuota", "<unknown key>") | |||
There was a problem hiding this comment.
unknown key -> unknown quota
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1348 +/- ##
==========================================
- Coverage 79.81% 79.72% -0.10%
==========================================
Files 277 277
Lines 13589 13592 +3
==========================================
- Hits 10846 10836 -10
- Misses 2743 2756 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
normandy7
reviewed
May 31, 2023
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
normandy7
approved these changes
Jun 1, 2023
aniezurawski
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting checklist