Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter empty directory files and compute hash w/o file metadata #1421

Merged

Conversation

artsiomtserashkovich
Copy link
Contributor

@artsiomtserashkovich artsiomtserashkovich commented Aug 9, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@artsiomtserashkovich artsiomtserashkovich changed the title add new artifact api version that is filter empty directory files and compute hash w/o metadata info filter empty directory files and compute hash w/o file metadata Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 97.14% and project coverage change: +0.02% 🎉

Comparison is base (1977426) 79.45% compared to head (c793914) 79.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1421      +/-   ##
==========================================
+ Coverage   79.45%   79.48%   +0.02%     
==========================================
  Files         280      280              
  Lines       13875    13909      +34     
==========================================
+ Hits        11025    11056      +31     
- Misses       2850     2853       +3     
Flag Coverage Δ
e2e 71.36% <45.71%> (-0.02%) ⬇️
e2e-management 55.73% <37.14%> (-0.05%) ⬇️
e2e-s3 55.56% <45.71%> (-0.03%) ⬇️
e2e-s3-gcs 55.56% <45.71%> (-0.03%) ⬇️
e2e-standard 71.16% <45.71%> (-0.02%) ⬇️
macos 79.28% <97.14%> (+0.05%) ⬆️
py3.10 71.25% <45.71%> (-8.11%) ⬇️
py3.7 78.96% <97.14%> (+0.02%) ⬆️
py3.7.16 70.51% <45.71%> (-8.21%) ⬇️
py3.8 ?
py3.9 ?
ubuntu 79.23% <97.14%> (+<0.01%) ⬆️
unit 73.15% <91.42%> (-0.59%) ⬇️
windows 79.23% <97.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ne/internal/backends/hosted_artifact_operations.py 89.61% <90.90%> (+0.05%) ⬆️
src/neptune/internal/artifacts/file_hasher.py 100.00% <100.00%> (ø)
src/neptune/internal/backends/api_model.py 97.04% <100.00%> (+0.10%) ⬆️
...eptune/internal/backends/hosted_neptune_backend.py 77.62% <100.00%> (+0.10%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artsiomtserashkovich artsiomtserashkovich marked this pull request as ready for review August 10, 2023 09:29
@artsiomtserashkovich artsiomtserashkovich merged commit db19229 into master Aug 10, 2023
29 checks passed
@artsiomtserashkovich artsiomtserashkovich deleted the filter_directory_files_and_hash_without_metadata branch August 10, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants