Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ensure_disk_not_full more reliable for env specific errors #1519

Merged
merged 8 commits into from
Oct 12, 2023
Merged

Make ensure_disk_not_full more reliable for env specific errors #1519

merged 8 commits into from
Oct 12, 2023

Conversation

artsiomtserashkovich
Copy link
Contributor

@artsiomtserashkovich artsiomtserashkovich commented Oct 12, 2023 •
edited
Loading

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@artsiomtserashkovich artsiomtserashkovich changed the title Made ensure_disk_not_full more reliable for env specific errors Make ensure_disk_not_full more reliable for env specific errors Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
src/neptune/internal/utils/disk_full.py 80.00% <100.00%> (+23.58%) ⬆️

... and 104 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@artsiomtserashkovich artsiomtserashkovich merged commit 8e74da9 into master Oct 12, 2023
4 checks passed
@artsiomtserashkovich artsiomtserashkovich deleted the at/more_defensive_full_disk branch October 12, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderWWW AleksanderWWW AleksanderWWW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artsiomtserashkovich @AleksanderWWW