Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MetadataFile to store internal informations about Neptune objects #1526

Merged
merged 20 commits into from
Oct 16, 2023

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Oct 13, 2023

The idea is to store information about internal container structure, operations version etc. The goal is to simplify the implementation of neptune.cli that currently it needs to use a lot of assumptions to support old client structures.

Screenshot 2023-10-13 at 22 58 15

Sample content:
Screenshot 2023-10-13 at 22 58 32


Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/neptune/internal/metadata_file.py 100.00% <100.00%> (ø)
.../operation_processors/async_operation_processor.py 84.18% <100.00%> (+0.58%) ⬆️
...peration_processors/offline_operation_processor.py 83.78% <100.00%> (+1.96%) ⬆️
...l/operation_processors/sync_operation_processor.py 84.61% <100.00%> (+3.36%) ⬆️
src/neptune/internal/operation_processors/utils.py 84.61% <84.61%> (ø)

... and 104 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

AleksanderWWW
AleksanderWWW previously approved these changes Oct 16, 2023
@Raalsky Raalsky merged commit 4ac9a89 into master Oct 16, 2023
4 checks passed
@Raalsky Raalsky deleted the rj/metadata-file branch October 16, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants