Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework disk usage limitation #1549

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Rework disk usage limitation #1549

merged 7 commits into from
Nov 8, 2023

Conversation

artsiomtserashkovich
Copy link
Contributor

@artsiomtserashkovich artsiomtserashkovich commented Oct 30, 2023 •
edited
Loading

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Rework disk usage limitation: use single env var instead of 2 / add a…
6ebb778 
…dditional validations for input value / add additional warnings
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
.../operation_processors/async_operation_processor.py 85.22% <100.00%> (ø)
...peration_processors/offline_operation_processor.py 83.78% <100.00%> (ø)
...l/operation_processors/sync_operation_processor.py 84.61% <100.00%> (ø)
src/neptune/internal/utils/disk_utilization.py 100.00% <100.00%> (ø)

... and 107 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@artsiomtserashkovich artsiomtserashkovich marked this pull request as ready for review October 30, 2023 12:57
Raalsky
Raalsky reviewed Oct 31, 2023
View reviewed changes
src/neptune/envs.py Outdated Show resolved Hide resolved
@artsiomtserashkovich artsiomtserashkovich changed the title Rework disk usage limitation: use single env var instead of 2 / add a… Rework disk usage limitation Nov 8, 2023
AleksanderWWW
AleksanderWWW previously approved these changes Nov 8, 2023
View reviewed changes
@artsiomtserashkovich artsiomtserashkovich merged commit 4288e9d into master Nov 8, 2023
4 checks passed
@artsiomtserashkovich artsiomtserashkovich deleted the at/rework_limit_disk_utilization branch November 8, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normandy7 normandy7 normandy7 left review comments

@Raalsky Raalsky Raalsky left review comments

@AleksanderWWW AleksanderWWW AleksanderWWW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artsiomtserashkovich @Raalsky @normandy7 @AleksanderWWW