Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify MetadataContainerNotFound message #1551

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

normandy7
Copy link
Collaborator

Clarifies the MetadataContainerNotFound exception message.
The current message can be difficult to understand if the user has mistakenly passed a custom/new ID to with_id. (Addresses #1541)

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@normandy7 normandy7 marked this pull request as ready for review November 2, 2023 07:44
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/neptune/exceptions.py 83.39% <100.00%> (-0.70%) ⬇️

... and 57 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@Raalsky Raalsky merged commit 0877fc7 into master Nov 10, 2023
4 checks passed
@Raalsky Raalsky deleted the sabine/clarify-mc-not-found branch November 10, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants