Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move prepare_nql_query to a separate function #1568

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Nov 16, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1e090e) 79.95% compared to head (145edb2) 76.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1568      +/-   ##
==========================================
- Coverage   79.95%   76.34%   -3.62%     
==========================================
  Files         286      287       +1     
  Lines       14360    14362       +2     
==========================================
- Hits        11481    10964     -517     
- Misses       2879     3398     +519     
Flag Coverage Δ
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 73.31% <100.00%> (-6.30%) ⬇️
py3.7 73.60% <100.00%> (-5.77%) ⬇️
py3.9 ?
ubuntu 73.46% <100.00%> (-6.16%) ⬇️
unit 73.60% <100.00%> (-0.57%) ⬇️
windows 72.77% <100.00%> (-6.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AleksanderWWW AleksanderWWW merged commit acb7d6a into master Nov 17, 2023
4 checks passed
@AleksanderWWW AleksanderWWW deleted the aw/prepare_nql_query_to_function branch November 17, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants