Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create monitoring namespace if all relevant flags are set to False #1575

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Nov 24, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f927f95) 79.94% compared to head (c5fcb35) 76.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1575      +/-   ##
==========================================
- Coverage   79.94%   76.40%   -3.54%     
==========================================
  Files         292      292              
  Lines       14518    14521       +3     
==========================================
- Hits        11606    11095     -511     
- Misses       2912     3426     +514     
Flag Coverage Δ
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 73.52% <100.00%> (-6.14%) ⬇️
py3.7 73.81% <100.00%> (-5.60%) ⬇️
py3.9 ?
ubuntu 73.67% <100.00%> (-6.05%) ⬇️
unit 73.81% <100.00%> (-0.58%) ⬇️
windows 72.99% <100.00%> (-6.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raalsky Raalsky merged commit e22833a into master Nov 24, 2023
4 checks passed
@Raalsky Raalsky deleted the aw/monitoring-namespace branch November 24, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants