Add message queue to AsyncOperationProcessor stopping
#1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1610 +/- ##
==========================================
- Coverage 80.09% 76.57% -3.52%
==========================================
Files 292 293 +1
Lines 14554 14618 +64
==========================================
- Hits 11657 11194 -463
- Misses 2897 3424 +527
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AleksanderWWW
changed the title
AsyncOperationProcessor stopping
Raalsky
reviewed
Jan 11, 2024
src/neptune/internal/operation_processors/async_operation_processor.py
Outdated
Show resolved
Hide resolved
| waiting_start: float = monotonic() | ||
| time_elapsed: float = 0.0 | ||
| max_reconnect_wait_time: float = self.STOP_QUEUE_MAX_TIME_NO_CONNECTION_SECONDS if seconds is None else seconds | ||
|
|
||
| if initial_queue_size > 0: | ||
| if self._consumer.last_backoff_time > 0: | ||
| if msg_queue is not None: | ||
| msg_queue.put(None) # to block message queue from logging anything |
There was a problem hiding this comment.
I don't understand this part
src/neptune/internal/operation_processors/async_operation_processor.py
Outdated
Show resolved
Hide resolved
Raalsky
reviewed
Jan 12, 2024
Raalsky
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting checklist