Add support for Seaborn figures #1613

szysad · 2023-12-28T11:50:14Z

Before submitting checklist

Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
Did you ask the docs owner to review all the user-facing changes?

Additionally: 1. Adds related e2e tests 2. Renames 'is_seaborn_axisgrid' to 'is_seaborn_figure'

codecov · 2023-12-28T11:54:58Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8013fc4) 80.09% compared to head (ef2eddd) 73.84%.

Files	Patch %	Lines
src/neptune/internal/utils/images.py	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1613      +/-   ##
==========================================
- Coverage   80.09%   73.84%   -6.25%     
==========================================
  Files         292      292              
  Lines       14554    14278     -276     
==========================================
- Hits        11657    10544    -1113     
- Misses       2897     3734     +837

Flag	Coverage Δ
e2e	`?`
e2e-	`?`
e2e-management	`?`
e2e-s3	`?`
e2e-s3-gcs	`?`
e2e-standard	`?`
macos	`73.56% <91.66%> (-6.27%)`	⬇️
macos-latest	`?`
py3.10	`?`
py3.7	`73.84% <91.66%> (-5.61%)`	⬇️
py3.7.16	`?`
py3.8	`?`
py3.9	`?`
ubuntu	`73.70% <91.66%> (-6.01%)`	⬇️
ubuntu-latest	`?`
unit	`73.84% <91.66%> (-0.54%)`	⬇️
windows	`73.02% <91.66%> (-6.64%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/neptune/internal/utils/images.py

tests/unit/neptune/new/internal/utils/test_images.py

tests/e2e/plot_utils.py

AleksanderWWW · 2024-01-02T19:08:48Z

@szysad
My bad, forgot to let you know to start your branch name with your initials - let's do that in the future PRs :)

AleksanderWWW · 2024-01-02T19:20:44Z

E2E ✅

https://github.com/neptune-ai/neptune-client/actions/runs/7389442981

CHANGELOG.md

AleksanderWWW · 2024-01-04T10:03:54Z

src/neptune/internal/utils/images.py

+SEABORN_GRID_CLASSES = set(
+    [
+        "FacetGrid",
+        "PairGrid",
+        "JointGrid",
+    ]
+)


While this is technically correct, the syntax is slightly confusing and IDEs like PyCharm complain about it.
Let's replace it with a set literal:
SEABORN_GRID_CLASSES = {"FacetGrid", "PairGrid", "JointGrid"}

Also, what happened to 'pairplot' and 'jointplot'?

pairplot and jointplot are functions provided to user in seaborn axisgrid but they always return instances of FacetGrid, PairGrid or JointGrid so it was redundant in the first place

- fix `generate_seaborn_figure` function so it works with seabron 0.11.2 - move seaborn grid classes list to const var - fix CHANGELOG.md header format - apply given-when-then test comment convention

Raalsky · 2024-01-08T14:11:25Z

pyproject.toml

@@ -45,6 +45,7 @@ altair = { version = "*", optional = true }
 bokeh = { version = "*", optional = true }
 freezegun = { version = "*", optional = true }
 matplotlib = { version = "*", optional = true }
+seaborn = { version = "*", optional = true }


We have to add it as a part of dev group as well (see lines between 112 and 143) 😉. This works as seaborn is probably a dependency of some of the other packages.

Szymon Sadkowski added 2 commits December 28, 2023 12:48

add seaborn figure support utils and respective unit tests

08b1045

Enable seaborn figure support in File atom

36d6afb

Additionally: 1. Adds related e2e tests 2. Renames 'is_seaborn_axisgrid' to 'is_seaborn_figure'

Szymon Sadkowski added 2 commits December 28, 2023 13:58

update changelog

cc290e3

update changelog version

c7769c1

szysad requested review from normandy7, Raalsky, kgodlewski and AleksanderWWW December 28, 2023 13:13

szysad marked this pull request as ready for review December 28, 2023 13:26

szysad marked this pull request as draft December 28, 2023 13:31

include Seaborn in File docstrings

1d4013d

szysad marked this pull request as ready for review December 28, 2023 13:41

normandy7 previously approved these changes Dec 28, 2023

View reviewed changes

SiddhantSadangi linked an issue Dec 28, 2023 that may be closed by this pull request

Feature Request: Add support for Seaborn figures #832

Closed

AleksanderWWW reviewed Jan 2, 2024

View reviewed changes

src/neptune/internal/utils/images.py Outdated Show resolved Hide resolved

tests/unit/neptune/new/internal/utils/test_images.py Show resolved Hide resolved

tests/e2e/plot_utils.py Outdated Show resolved Hide resolved

AleksanderWWW reviewed Jan 2, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

szysad dismissed normandy7’s stale review via ed968d4 January 4, 2024 09:47

szysad force-pushed the dev/seaborn-figures-support branch from ed968d4 to 3fd4cd6 Compare January 4, 2024 09:56

AleksanderWWW reviewed Jan 4, 2024

View reviewed changes

implement changes from code review

ef2eddd

- fix `generate_seaborn_figure` function so it works with seabron 0.11.2 - move seaborn grid classes list to const var - fix CHANGELOG.md header format - apply given-when-then test comment convention

szysad force-pushed the dev/seaborn-figures-support branch from 3fd4cd6 to ef2eddd Compare January 4, 2024 10:07

szysad requested a review from AleksanderWWW January 4, 2024 10:28

AleksanderWWW approved these changes Jan 4, 2024

View reviewed changes

szysad merged commit 51a8377 into master Jan 4, 2024
4 checks passed

szysad deleted the dev/seaborn-figures-support branch January 4, 2024 13:49

Raalsky reviewed Jan 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Seaborn figures #1613

Add support for Seaborn figures #1613

szysad commented Dec 28, 2023 •

edited

Loading

codecov bot commented Dec 28, 2023 •

edited

Loading

AleksanderWWW commented Jan 2, 2024

AleksanderWWW commented Jan 2, 2024

AleksanderWWW Jan 4, 2024

szysad Jan 4, 2024 •

edited

Loading

Raalsky Jan 8, 2024

Add support for Seaborn figures #1613

Add support for Seaborn figures #1613

Conversation

szysad commented Dec 28, 2023 • edited Loading

Before submitting checklist

codecov bot commented Dec 28, 2023 • edited Loading

Codecov Report

AleksanderWWW commented Jan 2, 2024

AleksanderWWW commented Jan 2, 2024

E2E ✅

AleksanderWWW Jan 4, 2024

Choose a reason for hiding this comment

szysad Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

Raalsky Jan 8, 2024

Choose a reason for hiding this comment

szysad commented Dec 28, 2023 •

edited

Loading

codecov bot commented Dec 28, 2023 •

edited

Loading

szysad Jan 4, 2024 •

edited

Loading