disable del and pop in handler #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1729 +/- ##
==========================================
- Coverage 78.21% 73.74% -4.48%
==========================================
Files 242 242
Lines 12787 12620 -167
==========================================
- Hits 10001 9306 -695
- Misses 2786 3314 +528
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Raalsky
approved these changes
Apr 10, 2024
| raise NeptuneUnsupportedFunctionalityException() | ||
|
|
||
| @check_protected_paths | ||
| def pop(self, path: str = None, *, wait: bool = False) -> None: |
There was a problem hiding this comment.
@normandy7 We're missing docstrings here. Would you mind to add it to your "backlog" and try to add it in a separate PR? https://docs.neptune.ai/api/client_index/#pop That's on metadata level like:
run["parameters/learninggg_rata"].pop()
There was a problem hiding this comment.
Sure, I will add it to my backlog that actually exists ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting checklist