Fixed compatibility checks with pre-release versions #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raalsky
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1730 +/- ##
==========================================
- Coverage 77.93% 73.55% -4.38%
==========================================
Files 244 244
Lines 12960 12775 -185
==========================================
- Hits 10100 9397 -703
- Misses 2860 3378 +518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
szysad
approved these changes
Apr 10, 2024
| raise NeptuneClientUpgradeRequiredError(version, min_version=client_config.version_info.min_compatible) | ||
| if client_config.version_info.max_compatible and client_config.version_info.max_compatible < version_with_patch_0: | ||
|
|
||
| if max_compatible and max_compatible < version_with_patch_0: |
There was a problem hiding this comment.
Why when checking whether client version is too big we extend possible micro versions?
Ex. if version = 1.5.10 and max_compatible = 1.5.0 we are not raising exception
There was a problem hiding this comment.
I don't know :<. Maybe someone set 0.10.0 instead of 0.10.9999 for some already delivered self hosted environment and that was easier to do it in client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting checklist