Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable artifact-related methods in handler + deco #1734

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Apr 11, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 40.90909% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 73.44%. Comparing base (e946c70) to head (f7cad20).
Report is 3 commits behind head on master.

Files Patch % Lines
src/neptune/handler.py 40.90% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1734      +/-   ##
==========================================
- Coverage   77.92%   73.44%   -4.49%     
==========================================
  Files         244      243       -1     
  Lines       12958    12762     -196     
==========================================
- Hits        10098     9373     -725     
- Misses       2860     3389     +529     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 73.31% <40.90%> (-4.53%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 73.44% <40.90%> (-3.86%) ⬇️
py3.7.16 ?
py3.8 ?
py3.9 ?
ubuntu 73.39% <40.90%> (-4.47%) ⬇️
unit 73.44% <40.90%> (-0.77%) ⬇️
windows 72.33% <40.90%> (-5.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AleksanderWWW
Copy link
Contributor Author

AleksanderWWW commented Apr 11, 2024

@AleksanderWWW AleksanderWWW merged commit b6325fd into master Apr 12, 2024
4 checks passed
@AleksanderWWW AleksanderWWW deleted the aw/disable-artifact-methods branch April 12, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants