Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default params for getAttributesWithPathsFilter #1740

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Apr 15, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.43%. Comparing base (b6325fd) to head (cad6d0e).

Files Patch % Lines
...eptune/internal/backends/hosted_neptune_backend.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1740      +/-   ##
==========================================
- Coverage   77.55%   73.43%   -4.12%     
==========================================
  Files         243      243              
  Lines       12946    12757     -189     
==========================================
- Hits        10040     9368     -672     
- Misses       2906     3389     +483     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 73.30% <0.00%> (-4.17%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 73.43% <0.00%> (-3.49%) ⬇️
py3.7.16 ?
py3.8 ?
py3.9 ?
ubuntu 73.31% <0.00%> (-4.18%) ⬇️
unit 73.43% <0.00%> (-0.68%) ⬇️
windows 72.32% <0.00%> (-4.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raalsky Raalsky merged commit 5595eb7 into master Apr 15, 2024
4 checks passed
@Raalsky Raalsky deleted the rj/fix-default-params branch April 15, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants