Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warning about interactive sessions #1819

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

szaganek
Copy link

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@szaganek szaganek requested a review from normandy7 June 18, 2024 13:08
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.61%. Comparing base (f23629b) to head (c40e6d4).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.x    #1819      +/-   ##
===========================================
- Coverage    81.21%   75.61%   -5.61%     
===========================================
  Files          304      304              
  Lines        15371    15365       -6     
===========================================
- Hits         12484    11618     -866     
- Misses        2887     3747     +860     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 75.27% <ø> (-5.70%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 74.99% <ø> (-5.59%) ⬇️
py3.8 75.27% <ø> (-5.79%) ⬇️
py3.9 ?
ubuntu 74.86% <ø> (-6.12%) ⬇️
unit 75.61% <ø> (-0.03%) ⬇️
windows 73.89% <ø> (-6.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szaganek szaganek merged commit 76e1144 into dev/1.x Jun 18, 2024
4 checks passed
@szaganek szaganek deleted the er/interactive-sessions-warning branch June 18, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants