Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed support for additional seaborn images #1864

Merged
merged 14 commits into from
Oct 1, 2024
Merged

Conversation

SiddhantSadangi
Copy link
Member

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.59%. Comparing base (6c28d77) to head (5766857).
Report is 12 commits behind head on dev/1.x.

Files with missing lines Patch % Lines
src/neptune/legacy/internal/utils/image.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.x    #1864      +/-   ##
===========================================
- Coverage    81.20%   75.59%   -5.62%     
===========================================
  Files          303      304       +1     
  Lines        15374    15380       +6     
===========================================
- Hits         12484    11626     -858     
- Misses        2890     3754     +864     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 75.30% <80.00%> (-1.97%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 ?
py3.8 75.57% <80.00%> (-1.92%) ⬇️
py3.9 ?
ubuntu 75.38% <80.00%> (-5.66%) ⬇️
unit 75.57% <80.00%> (-0.10%) ⬇️
windows 74.43% <80.00%> (-6.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SiddhantSadangi SiddhantSadangi marked this pull request as draft September 6, 2024 10:14
@SiddhantSadangi SiddhantSadangi requested review from PatrykGala and removed request for szysad September 26, 2024 12:33
@SiddhantSadangi SiddhantSadangi marked this pull request as ready for review September 27, 2024 09:27
@SiddhantSadangi SiddhantSadangi added this to the 1.12.0 milestone Sep 27, 2024
normandy7
normandy7 previously approved these changes Sep 30, 2024
@SiddhantSadangi SiddhantSadangi dismissed normandy7’s stale review September 30, 2024 11:38

The merge-base changed after approval.

normandy7
normandy7 previously approved these changes Sep 30, 2024
@SiddhantSadangi SiddhantSadangi dismissed normandy7’s stale review September 30, 2024 11:48

The merge-base changed after approval.

PatrykGala
PatrykGala previously approved these changes Oct 1, 2024
@SiddhantSadangi SiddhantSadangi dismissed PatrykGala’s stale review October 1, 2024 08:30

The merge-base changed after approval.

AleksanderWWW
AleksanderWWW previously approved these changes Oct 1, 2024
@SiddhantSadangi SiddhantSadangi dismissed AleksanderWWW’s stale review October 1, 2024 08:41

The merge-base changed after approval.

normandy7
normandy7 previously approved these changes Oct 1, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@SiddhantSadangi SiddhantSadangi dismissed normandy7’s stale review October 1, 2024 11:35

The merge-base changed after approval.

Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
@SiddhantSadangi SiddhantSadangi merged commit 2c5aaca into dev/1.x Oct 1, 2024
4 checks passed
@SiddhantSadangi SiddhantSadangi deleted the ss/seaborn branch October 1, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants