Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return path from requested prefix instead of root when fetching namespace #609

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

pkasprzyk
Copy link
Contributor

ref. https://neptune-labs.atlassian.net/browse/NPT-10417

before:

import neptune.new as neptunerun = neptune.init()
run['model/params'] = {'a': 3}
run.wait()
params run['model/params'].fetch() == {'model': {'params': {'a': 3}}}

after:

import neptune.new as neptunerun = neptune.init()
run['model/params'] = {'a': 3}
run.wait()
params run['model/params'].fetch() == {'a': 3}

Also refactored fetch_atom_attribute_values to make it more unit-testable.

neptune/new/attributes/namespace.py Outdated Show resolved Hide resolved
neptune/new/attributes/namespace.py Show resolved Hide resolved
@pkasprzyk pkasprzyk merged commit f67814b into master Jul 1, 2021
@pkasprzyk pkasprzyk deleted the pk/NPT-10417-fix-fetch-structure branch July 1, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants