Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate model key and fix error handling #896

Merged
merged 6 commits into from
May 12, 2022
Merged

Validate model key and fix error handling #896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
764461d
Validate model key and fix error handling
aniezurawski May 12, 2022
ff1772d
Fix
aniezurawski May 12, 2022
72c787d
Add commment
aniezurawski May 12, 2022
86102d2
Fix
aniezurawski May 12, 2022
cd713c1
Fix
aniezurawski May 12, 2022
b4d484c
Changelog
aniezurawski May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
## [UNRELEASED] neptune-client 0.16.2
## [UNRELEASED] neptune-client 0.16.3


## neptune-client 0.16.2

## Features
- Sync only offline runs inside '.neptune' directory CLI flag ([#894](https://github.com/neptune-ai/neptune-client/pull/894))

## Fixes
- Fix handling of server errors ([#896](https://github.com/neptune-ai/neptune-client/pull/896))

## neptune-client 0.16.1

## Features
Expand Down
2 changes: 2 additions & 0 deletions neptune/new/internal/backends/hosted_neptune_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ def create_run(
additional_params=additional_params,
)

@with_api_exceptions_handler
def create_model(self, project_id: UniqueId, key: str = "") -> ApiExperiment:
additional_params = {
"key": key,
Expand All @@ -374,6 +375,7 @@ def create_model(self, project_id: UniqueId, key: str = "") -> ApiExperiment:
additional_params=additional_params,
)

@with_api_exceptions_handler
def create_model_version(
self, project_id: UniqueId, model_id: UniqueId
) -> ApiExperiment:
Expand Down