Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Yellowbrick-Matplotlib incompatibility #28

Merged
merged 10 commits into from
Apr 10, 2024

Conversation

SiddhantSadangi
Copy link
Member

@SiddhantSadangi SiddhantSadangi commented Mar 26, 2024

  • Monkey patched yellowbrick.regression.CooksDistance.draw() to remove unsupported use_line_collection matplotlib arg (#28)
  • Expanded e2e test matrix to include Python 3.8, 3.10, and 3.12
  • Replaced print() with warning() to capture stderr

@SiddhantSadangi SiddhantSadangi self-assigned this Mar 26, 2024
@SiddhantSadangi SiddhantSadangi requested review from normandy7 and removed request for normandy7 March 26, 2024 12:59
Copy link
Contributor

@normandy7 normandy7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will this warrant any mention/change in the docs?

@SiddhantSadangi
Copy link
Member Author

Will this warrant any mention/change in the docs?

Nope.. Just a mention in the changelog as "Fix for "Error logging Cook's Distace" on matplotlib>=3.12"

@SiddhantSadangi SiddhantSadangi merged commit 6dff9b6 into master Apr 10, 2024
11 checks passed
@SiddhantSadangi SiddhantSadangi deleted the ss/fix_yellowbrick_mpl branch April 10, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants