Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ColdFront text "Expired" to "Active (Needs Renewal)" #588 #120

Closed
QuanMPhm opened this issue Jun 3, 2024 · 5 comments · Fixed by #121
Closed

Update ColdFront text "Expired" to "Active (Needs Renewal)" #588 #120

QuanMPhm opened this issue Jun 3, 2024 · 5 comments · Fixed by #121
Assignees

Comments

@QuanMPhm
Copy link
Contributor

QuanMPhm commented Jun 3, 2024

Copied from nerc-project/operations#588, we want to rename the allocation status "Expired" to "Active (Needs Renewal)"

@QuanMPhm QuanMPhm self-assigned this Jun 3, 2024
@QuanMPhm
Copy link
Contributor Author

QuanMPhm commented Jun 3, 2024

@knikolla For this, it seems the solution would be to change every instance of the string "'Expired'" (single quotes included) in every file of the coldfront module. This will result in changes to several files. Is it fine if I add a patch file to do this?

@knikolla
Copy link
Collaborator

knikolla commented Jun 3, 2024

Looking, will have an answer in by End of Day.

@knikolla
Copy link
Collaborator

knikolla commented Jun 7, 2024

I would suggest looking into creating a new status and changing only the string in the recurrent task that switches projects from Active to Expired when the end date arrives.

We're going to be carrying this as a patch here in the patches folder, so we want to minimize the risk of merge conflicts as time goes on.

@joachimweyl joachimweyl self-assigned this Jun 10, 2024
@joachimweyl
Copy link

@QuanMPhm do you have what you need to take the next steps on this?

@QuanMPhm
Copy link
Contributor Author

@joachimweyl Yes, I will work on it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants