Added new allocation status "Active (Needs Renewal)" #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtriley
requested changes
Jun 17, 2024
There was a problem hiding this comment.
@QuanMPhm we also need to include the patch in the Dockerfile:
https://github.com/nerc-project/coldfront-nerc/blob/main/Dockerfile#L30
jtriley
reviewed
Jun 17, 2024
When any Coldfront expires, the allocation's status will change to "Active (Needs Renewal)" instead of "Expired"
QuanMPhm
force-pushed
the
120/add_needs_renewal_status
branch
from
bc1301b
to
8da0953
Compare
jtriley
approved these changes
Jun 18, 2024
Closed
22 tasks
|
@knikolla When the patched command is ran on a Coldfront with the old defaults, the new |
|
@QuanMPhm what are next steps to get this merged? |
|
@joachimweyl I suppose I'll merge it now. I was just waiting for someone with more seniority to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #120. When any Coldfront expires, the allocation's status will change to "Active (Needs Renewal)" instead of "Expired"