Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to create new pull request. #167

Merged
merged 6 commits into from
May 23, 2023

Conversation

ps2
Copy link
Contributor

@ps2 ps2 commented May 8, 2023

These changes allow the creation of a new pull request using the Octokit package.

I tried following the existing code patterns as best I could. Let me know if you have any feedback. Thanks!

Copy link
Member

@pietbrauer pietbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Please also add the async/await compatible version.

OctoKit/PullRequest.swift Outdated Show resolved Hide resolved
OctoKit/PullRequest.swift Outdated Show resolved Hide resolved
OctoKit/PullRequest.swift Outdated Show resolved Hide resolved
OctoKit/PullRequest.swift Outdated Show resolved Hide resolved
OctoKit/PullRequest.swift Outdated Show resolved Hide resolved
@ps2 ps2 requested a review from pietbrauer May 8, 2023 22:11
Copy link
Member

@pietbrauer pietbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Something I totally forgot yesterday was that some tests would also be really nice.

@ps2
Copy link
Contributor Author

ps2 commented May 10, 2023

Added tests, thanks!

@ps2 ps2 requested a review from pietbrauer May 10, 2023 16:46
pietbrauer
pietbrauer previously approved these changes May 11, 2023
pietbrauer
pietbrauer previously approved these changes May 21, 2023
@pietbrauer
Copy link
Member

@ps2 Linting is still failing sadly otherwise it's good to go.

@pietbrauer pietbrauer merged commit 61be8eb into nerdishbynature:main May 23, 2023
@ps2 ps2 deleted the create-pull-request branch August 10, 2023 15:07
@ps2 ps2 restored the create-pull-request branch August 10, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants