Add support for extraEnvFrom variables #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cristiangreco The Lint check failed for my pull request because my commit did not include a version bump to the helm chart. Do I need to update the pull request with a bump to the version of the helm chart? If so, is it correct to assume that the version should be bumped to '0.27.0', since the current helm chart version is now '0.26.0'? |
|
@brophyja please go ahead and bump the version to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an enhancement to the Helm chart to add support for 'extraEnvFrom' environment variables from secrets or configmaps.
This capability is useful in scenarios when secrets need to be passed as environment variables to the running container.