fixed a hang bug in ray_marching #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed a hang bug where t_target has inf value ( ray is parralel to plane ?) t_target should be larger that far anyway
|
LGTM! thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed a hang bug where t_target has inf value ( ray is parralel to plane ?) t_target should not be larger that far anyway
@tancik I found the hang bug -
t_target got inf value.
if we bound it by far - it fixes the issue.
This is related to nerfstudio-project/nerfstudio#1152.
The problem is that I see that nerfstudio is incompatible with the newest version of nerfacc, so a work needs to be done in nerfstudio to upgrade nerfacc.